Initial Object Store implementation #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtmk
changed the title
caleblloyd
reviewed
Oct 17, 2023
| @@ -18,6 +18,21 @@ public interface ICountableBufferWriter : IBufferWriter<byte> | |||
| int WrittenCount { get; } | |||
| } | |||
|
|
|||
| public readonly struct FixedSizeMemoryOwner : IMemoryOwner<byte> | |||
There was a problem hiding this comment.
Out of curiosity, what is the benefit of using this over MemoryPool<byte>.Shared ?
There was a problem hiding this comment.
MemoryPool.Shared.Rent returns at least the size asked for, which usually rounds up to some 2^n. This wrapper chops the memory to exact size so when it's passed to stream read/write or down the line to publish or something you won't need to pass the actual size.
There was a problem hiding this comment.
btw, we are still renting it from MemoryPool.
There was a problem hiding this comment.
btw, we are still renting it from MemoryPool.
Ah, I see that now. Clever!
# Conflicts: # NATS.Client.sln
caleblloyd
reviewed
Oct 17, 2023
caleblloyd
reviewed
Oct 17, 2023
Missed one!
caleblloyd
reviewed
Oct 17, 2023
Co-authored-by: Caleb Lloyd <[email protected]>
mtmk
added a commit
that referenced
this pull request
Oct 20, 2023
mtmk
added a commit
that referenced
this pull request
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object store initial implementation.
Features:
Missing features: